question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add support for amp-embedly

See original GitHub issue

Create a component that uses’s Embedly’s API to embed any provider supported by Embedly.

Note: Embedly is a paid service and publisher needs to provide their own key.

API

<amp-embedly key=<yourAPIKey> url=<embedUrl> width height layout>

Implementation details:

1- We make a call to embedly’s oembed API 2- It returns data including some html to render. 3- We add the html and watch for resize events and resize our components accordingly.

NOTE: we can NOT trust the html return by embedly and just inject it. Therefor this component as a whole needs to live in a 3P iframe similar to amp-gist or amp-twitter

/to @juanlizarazo /cc @jpettitt @ericlindley-g

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:13 (13 by maintainers)

github_iconTop GitHub Comments

1reaction
juanlizarazocommented, Apr 24, 2018

@aghassemi @alanorozco New PR #14819 is up and ready for review 😁

1reaction
juanlizarazocommented, Apr 24, 2018

Little update here!

This is the current status, I am aiming to finish the remaining tasks in the next few days.

I closed PR #13843 because the new amp-embedly-card component’s implementation is quite different. I will create a new one once this is ready.

  • Create and register extension.
  • Do not trust html, use 3p iframe.
  • Parse url data attributes.
  • Load external script in 3p iframe
  • Render card
  • Listen for resize events
  • amp-embedly-key component, when key provided, branding is removed.
  • Allow customization options
  • Update validator definition
  • Documentation.
  • Unit tests.

@aghassemi @alanorozco

Read more comments on GitHub >

github_iconTop Results From Across the Web

Documentation: <amp-embedly-card> - amp.dev
Specifies which image to use in article cards when data-url points to an article. Not all image URLs are supported, if the image...
Read more >
ampproject/amphtml 1811202257200 on GitHub - NewReleases.io
amp-subscriptions platform reset all platforms on reauthorise (#19384); Always set theme color to background color ✓ (#19391); ♻️ Add DomElement type for ...
Read more >
Documentation: <amp-beopinion> - amp.dev
The amp-beopinion component allows you to embed BeOpinion content in your AMP page for a given BeOpinion account. BeOpinion is a tool for...
Read more >
Alberto on Twitter: "@nainar92 @AMPhtml Thanks Naia, I guess you ...
We don't currently, however you could use the <amp-embedly-card> component ... Add a component to display Tiktok posts · Issue #27080 · ampproject/amphtml....
Read more >
examples · 2012112254001 · mirrors / ampproject / amphtml · GitCode
ads-legacy.amp.html · ✨ Add basic GDPR support for AdUp Technology ad tags (#29490) ... amp-embedly-card.amp.html · ✨ implement amp-embedly-card component ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found