question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Always overwrite target attribute for amp-story-cta-layer a to _top

See original GitHub issue

Any <a> tags descending from <amp-story-cta-layer> should have their target attribute set/rewritten to _topin the AmpStoryCtaLayer buildCallback().

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:8 (7 by maintainers)

github_iconTop GitHub Comments

2reactions
jonsherrardcommented, Mar 20, 2018

Hello @newmuis!

Could this possibly be configurable, I can already think of use cases where I’d want both?

I can understand why you’d not want to use _self or _parent, but I think a choice between _top or _blank would be really helpful in userland.

Thanks for all your work on this project by the way - really love stories as a format.

Ciao for now!

x

0reactions
newmuiscommented, Mar 29, 2018

#14275 fixes the history issue mentioned above, so we can start work on this now, to be merged after #14275 is merged.

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to Force cp Command to Overwrite without Confirmation
In this guide, we will show how to force the cp command to overwrite a copy operation without confirmation in Linux.
Read more >
How to Override `<base target="_blank">` - Stack Overflow
Is there a way to override <base target="_blank"/> just for the search results? <form action="/search" method="get" class="sfm"> <input ...
Read more >
How to move and overwrite subdirectories (and files) to parent ...
Always BE CAREFUL when using rm -rf , be sure to specify the folder name at the end and to not use variables...
Read more >
Will not overwrite some files - Flexera Community
I have set Always Overwrite on some of my files and on an Update or Repair install they are still not getting overwritten....
Read more >
Options Controlling the Overwriting of Existing Files - GNU.org
The ' --overwrite-dir ' option enables this default behavior. To be more cautious and preserve the metadata of such a directory, use the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found