question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

amp-apester-media: Element mutation outside mutation phase

See original GitHub issue

amp-apester-media inserts its iframe inside #layoutCallback, but because it’s inside a Promise’s then chain, it’s outside of a mutation phase.

layoutCallback() {
  this.element.classList.add('amp-apester-container');
  // This is inside the mutation phase

  return this.queryMedia_().then(response => {
    // We're no longer inside mutation phase, due to promise's
    // async resolution.
    this.element.appendChild(iframe);
  });
}

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:9 (9 by maintainers)

github_iconTop GitHub Comments

1reaction
aghassemicommented, Jun 19, 2018

fixed by #13741

1reaction
OmriKeretcommented, Feb 24, 2018

Hi guys, I will gladly fix it with our next PR (ETA - end of next week).

@aghassemi Is it soon enough?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Do not mutate vuex store state outside mutation handlers
Error [vuex] Do not mutate vuex store state outside mutation handlers. What does it mean? It happens when I try to type in...
Read more >
Mutations
The only way to actually change state in a Vuex store is by committing a mutation. Vuex mutations are very similar to events:...
Read more >
"Do not mutate store state outside mutation handler" error ...
What is expected? the state is changed and a notification is shown as expected but i dont get an error in the console ......
Read more >
Resolve "do not mutate vuex store state outside ... - GitLab
After enabling Vuex's strict mode in !918 (merged), a number of "do not mutate vuex store state outside mutation handlers" warnings started showing...
Read more >
[vuex] Do not mutate vuex store state outside ...
I got the point that we cannot change the data (state) from the getter and the function sort change the products array so...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found