Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

amp-embed displays amp-ad loading placeholder

See original GitHub issue

amp-embed is displaying the new amp-ad loading animation. Since they are semantically different (amp-embed is theoretically not an ad) this is incorrect.

Issue Analytics

State:
Created 7 years ago
Comments:6 (6 by maintainers)

Top GitHub Comments

1reaction

cramforcecommented, Feb 24, 2017

I think removing the indicator is fine.

We should not allow amp-embed for things that are really just ads. It is a whitelist. I know it is a grey area.

0reactions

jpettittcommented, Feb 24, 2017

@jasti we have a 3p amp-embed in the works that will not be just an ad.

Top Results From Across the Web

amp-ad - Documentation

A container to display an ad. ... Example: Displaying a few ads. Ad. Ad. <amp-ad ... <amp-ad width="300" height="250" type="foo"> <div placeholder>Loading ....

For amp-ad, provide placeholder animation while ad is loading

I'd still argue that showing animation on ad loading is not a right approach - it's not part of main content and should...

iframe within <amp-ad> tag is not resized - Stack Overflow

We're trying to resize "amp-ad" on the fly but the iframe containing the ads is displayed in 1x1 instead of 300x250. We do...

Content Placeholders: A Way to Style Waiting Time - CodePicky

You can personalise your loading state with content placeholders ... These are simple mockups of the content that's going to be displayed.

Placeholder Loading Screens With Jetpack Compose - YouTube

In this live stream we looked at how to create a placeholder loading animation in Jetpack Compose using the Accompanist library.