Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Implement "halves" template for amp-story-grid-layer

See original GitHub issue

A FR has come in for a halves template that splits the screen into two equal sections, stacked vertically. This is akin to the thirds template, but with two sections instead of three.

Not sure if there’s a better name for this; perhaps one that implies the vertical orientation of the sections.

Issue Analytics

State:
Created 6 years ago
Comments:5 (2 by maintainers)

Top GitHub Comments

1reaction

gmajouletcommented, Oct 29, 2018

Of course, please mention me on your PR! If you need a code pointer to get started, here’s where the thirds template are declared: https://github.com/ampproject/amphtml/blob/master/extensions/amp-story/1.0/amp-story.css#L311

1reaction

newmuiscommented, Oct 29, 2018

Sure! Thanks for the contribution!

@gmajoulet may be a good person to review the code

Top Results From Across the Web

Documentation: <amp-story> - amp.dev

The component itself implements the UI shell, including handling gestures and navigation, and inserting the application shell UI (controls, progress bar, etc).

Rahul's Blog

Feel free to use it or deploy your own. Rest of the tutorial will work with deploying this sample application.

logo requirements from client

Use this attribute to specify the delay before starting the animation. ... The AMP story HTML format follows the same markup requirements as...

AMP istorijos su React ! (React pavyzdys) - Artefaktas.eu

to log results (for example: reportWebVitals(console.log)). // or send to an analytics endpoint. ... AmpStoryGridLayer,. AmpStory,. AmpStoryPage,. AmpImg,.

Untitled