Incomplete test files being found during CI
See original GitHub issueDescription
https://github.com/ampproject/amphtml/pull/35500 renamed the removeAutoplay
to removeAutoplay_
. In the same commit, there exists https://github.com/samouri/amphtml/blob/363f2bbad12f74d5699451350685e9e6479dfc66/extensions/amp-carousel/0.1/test/test-slidescroll.js, which still references removeAuotplay
and tries to stub it. This causes a test failure.
The only thing I can think of is that extensions/amp-carousel/0.1/test/test-slidescroll.js
was not found by the test grep, and so it didn’t fail.
Reproduction Steps
git checkout 6c7a2f0
(the squash commit)- npx amp unit --files ‘extensions/amp-carousel/0.1/test/test-slidescroll.js’
Relevant Logs
TypeError: Attempted to wrap undefined property removeAutoplay as function
at wrapMethod (home/circleci/project/node_modules/sinon/lib/sinon/util/core/wrap-method.js:114:21)
at Function.spy (home/circleci/project/node_modules/sinon/lib/sinon/spy.js:180:16)
at Sandbox.spy (home/circleci/project/node_modules/sinon/lib/sinon/sandbox.js:383:35)
at _callee22$ (home/circleci/project/extensions/amp-carousel/0.1/test/test-slidescroll.js:918:47)
at tryCatch (home/circleci/project/node_modules/fetch-mock/es5/client-bundle.js:1291:52)
at Generator.invoke [as _invoke] (home/circleci/project/node_modules/fetch-mock/es5/client-bundle.js:1521:34)
at Generator.next (home/circleci/project/node_modules/fetch-mock/es5/client-bundle.js:1346:33)
at asyncGeneratorStep (home/circleci/project/node_modules/@babel/runtime/helpers/asyncToGenerator.js:3:20)
at _next (home/circleci/project/node_modules/@babel/runtime/helpers/asyncToGenerator.js:25:9)
Browser(s) Affected
No response
OS(s) Affected
No response
Device(s) Affected
No response
AMP Version Affected
No response
Issue Analytics
- State:
- Created 2 years ago
- Reactions:1
- Comments:13 (13 by maintainers)
Top Results From Across the Web
"Find in files" search shows incomplete results #32325 - GitHub
Steps to Reproduce: Open a project and do a "find in files" search for anything valid. i.e. "foo"; Results should be incomplete, a...
Read more >Troubleshooting CI/CD - GitLab Docs
GitLab provides several tools to help make troubleshooting your pipelines easier. This guide also lists common issues and possible solutions.
Read more >ng test fails in angular universal Error "Incomplete: No specs ...
I got a lot of errors with the following in the tsconfig.spec.json file: "files": [ "test.ts", "polyfills.ts" ], "include": [ "**/*.spec.ts" ...
Read more >CI/CD pipelines explained: Everything you need to know
Planning to implement CI/CD? This comprehensive guide explores the stages of a CI/CD pipeline, its pros and cons, best practices and more.
Read more >How To Write Unit Tests in Go - DigitalOcean
By convention, Go testing files are always located in the same ... for your Subtract function — so we can view an incomplete...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Thanks for poking this thread, @samouri. Not tracking separately, but will send out a PR today to persist the filelist as a CircleCI artifact.
@rsimha: are we tracking https://github.com/ampproject/amphtml/issues/35580#issuecomment-895587167 anywhere? I often need to SSH into a CircleCI node to retrieve the filelist.