Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Invalid AMP validation for amp-lightbox

See original GitHub issue

Recently, a new “scrollable” tag was added to amp lightbox ( https://github.com/ampproject/amphtml/pull/6398 ).

This is the latest “everything AMP” example https://raw.githubusercontent.com/muxin/amphtml/361ec9e264b5bb7e8045c4677ceaf71fc714cc45/examples/everything.amp.html

However the validator considers it to be an invalid AMP. https://validator.ampproject.org/#url=https%3A%2F%2Fraw.githubusercontent.com%2Fmuxin%2Famphtml%2F361ec9e264b5bb7e8045c4677ceaf71fc714cc45%2Fexamples%2Feverything.amp.html

Specifically,

The attribute 'scrollable' may not appear in tag 'amp-lightbox'.

The AMP lightbox CDN version has the new code changes made in the PR, but it appears that the validator is not updated.

Issue Analytics

State:
Created 7 years ago
Comments:6 (4 by maintainers)

Top GitHub Comments

2reactions

honeybadgerdontcarecommented, Jan 13, 2017

This is now live in prod.

2reactions

Gregablecommented, Dec 20, 2016

It typically takes a few weeks for validator changes to roll out, with the holidays it’s a big longer. I’ll try to update this issue when it’s live.

Top Results From Across the Web

amphtml/validator-amp-lightbox.protoascii at main - GitHub

amphtml /extensions/amp-lightbox/validator-amp-lightbox.protoascii ... cannot be properly positioned in emails and will soon be invalid in AMP4EMAIL.".

AMP validation errors

Valid AMP documents must not include any validation errors. ... For example, one common trigger for this error is invalid values for URLs....

How to conditionaly open a lightbox on a submit-error?

1 Answer 1 · Redefining lightbox using CSS will loose the ESC or background click to close it, right ? So I guess...

AMP Page has validation errors | Sitebulb

If AMP pages are invalid this means they are either missing mandatory elements; including disallowed, depreciated or duplicated elements; or contains style, ...

AMP Hello World - your first AMP page - Packt Subscription

It consists of the AMP boilerplate code that will be used in every AMP page you write. ... AMP validation reports an error...