Request to limit scope of functions in validator.js

What’s the issue?

It seems that functions in validator.js are escaping into the global namespace.

How do we reproduce the issue?

1. Navigate to an AMP page like this, with #development=1 appended to the URL.
2. Open the browser’s console, and enter wp.
3. Expected: wp is not defined
4. Actual: wp is a function:

ƒ wp(a){rp.call(this);this.name=a;this.value=[];this.b=!1;this.o=34}

It looks like this script leaks functions into the global namespace:

https://cdn.ampproject.org/v0/validator.js

There are other functions leaked, like aa.

Maybe that script is intended for development only, as it seems that it’s not requested if #development=1 isn’t appended. But it would really help us with this issue on the AMP WordPress plugin:

https://github.com/Automattic/amp-wp/issues/843

We’re working on validating AMP in the WordPress editor.

What browsers are affected?

Chrome 63.0.3239.132

Which AMP version is affected?

1516337355291

Thanks a lot for your help 😄

/cc @amedina, @Gregable, @pbakaus

[Gregable]

I think we can get a fix out for this fairly quickly. @powdercloud has a prototype, but we need to get it through a release. Thanks for the report.

[kienstra]

Thank You

Hi @powdercloud and @Gregable, Thanks a lot for fixing this. As you mentioned, validator.js is wrapped in a function, and functions like wp aren’t leaked.