question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Support `playsfullscreen` on `amp-video`

See original GitHub issue

Authors should be able to specify where a video plays inline or full-screen when it starts playing.

Safari/iOS has always had good support for this feature but Chrome did not. We should polyfill Chrome.

play-fullscreen should behave as follows in ALL PLATFORMS:

  • When user taps the video to play or when the video is played through the play AMP action, it should go to native full-screen (not lightbox or fill)
  • If play-fullscreen is used with autoplay, video autoplays inline but when user taps the autoplaying video to unmute it, then it goes to full-screen (alternative it ignoring play-fullscreen when used with autoplay) @abeck000 thoughts?

Stretch goal: Support this attribute on <amp-youtube> and other players. (This feature is already half possible on amp-youtube by setting data-params-playsinline=0 but that only works on iOS)

/cc @rudygalfi

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Comments:12 (12 by maintainers)

github_iconTop GitHub Comments

1reaction
aghassemicommented, Jun 8, 2018

closing due to simple workaround documented above, don’t think it is worth polluting the API.

0reactions
aghassemicommented, Jun 8, 2018

Actually since we support fullscreen action. This can already be done.

<amp-video on="tap: video.play, video.fullscreen">

or

<amp-video on="firstPlay: video.fullscreen">
Read more comments on GitHub >

github_iconTop Results From Across the Web

Documentation: <amp-video> - amp.dev
The amp-video component accepts up to four unique types of HTML nodes as children: ... a fallback if the browser doesn't support HTML5...
Read more >
AMP Video: Home Page
Full-service, professional video hosting of AMP Video content or your video content — $384 add-on to any OPTIMA™ Program.
Read more >
Set a video to play full screen - Microsoft Support
Set a video in a PowerPoint presentation so that it plays full screen.
Read more >
Everything Digital Advertisers Must Know About AMP Video ...
Get all the details for every AMP video attribute and component here. ... Attributes; Common attributes; Layout; Analytics support; AMP video components ...
Read more >
Videos don't always allow "Full Screen". | Firefox Support Forum
Not every website that I visit allows videos to be viewed in full screen mode, why? I have followed the instructions on "how...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found