Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Use listenOnce in amp-story

See original GitHub issue

We have many places in amp-story code that add an event listener but do not remove it. For this, we can refactor to use listenOnce.

Issue Analytics

State:
Created 6 years ago
Comments:6 (6 by maintainers)

Top GitHub Comments

1reaction

juanlizarazocommented, Jul 23, 2018

@newmuis I attempted to use listenOnce but that one removes the listener as soon as the event is received, it just executes each handler once for each event, e.g. next page would work just once.

So instead, I refactored this with listen and stored the unlisteners than then are called in unlayoutCallback.

PR #17004 is ready for review.

c.c. @mrjoro

1reaction

newmuiscommented, Jul 11, 2018

Sure! Thanks @juanlizarazo!

Top Results From Across the Web

Event bus implementation for clickable actions in amp story

click listeners in stories needs to be centrally managed. The navigation service needs an API similar to the anchor mutators but not restricted ......