Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Validator rule change to support ads in story

See original GitHub issue

For #12381

<amp-story-auto-ads> has to be a direct child of <amp-story>
Each <amp-story> can only have one amp-story-auto-ads child.
<amp-story-auto-ads> takes no attributes, but a child element as its configuration: <script type="application/json">.
<amp-story-auto-ads> requires extension script amp-story-auto-ads.js
Allow <template> to be a direct child of <amp-story-auto-ads>
If <template> is a direct child of <amp-story-auto-ads>, all its descendants have to follow the same validation rules as <amp-story-grid-layer>
Other <template> rules apply, for example requiring a type attribute and the corresponding script tag in <head>

/cc @newmuis @Gregable

Issue Analytics

State:
Created 6 years ago
Comments:19 (19 by maintainers)

Top GitHub Comments

1reaction

Gregablecommented, Feb 27, 2018

OK, then the plan will be to create a new extension. In terms of separating this out, I recommend the hacky way for a short term, since we don’t want folks including a js file that 404s.

0reactions

calebcordrycommented, Jun 5, 2018

This is done.

Top Results From Across the Web

Updates to the style validation rules for search style ad settings

To improve the search ads experience for users and advertisers, we're updating the style validation rules for some search style ad settings.

Social Validation: Supercharge Your Ads With This Trick

Social validation places your ad under the spotlight and helps you convert. Read this article to find out more about this phenomenon.

Workflow Validator - Atlassian Developer

This module defines a validator that can be added to workflow transitions (see: Advanced workflow configuration ). Validators check that any input made...

Ad Campaign - Meta for Developers - Facebook

Setting objective of the campaign will enforce validation on any ads added to the campaign to ensure they also have the correct objective....

091005revisedendorsementguid... - Federal Trade Commission

45) to the use of endorsements and testimonials in advertising. The Guides provide the basis for voluntary compliance with the law by advertisers...