Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Move antlr4 dependency from python 2 to python 3

See original GitHub issue

All three microservices for Amundsen(data portal) could run on both python 2.x or python 3.x. The data ingestion library(amundsendatabuilder) could run only on python 2.x because of antlr4-python2-runtime.

It is used in ColumnUsage parser. We should explore and see if we could move the dependency to python 3(e.g. https://github.com/antlr/antlr4/tree/master/runtime/Python3)

Issue Analytics

State:
Created 5 years ago
Reactions:2
Comments:12 (12 by maintainers)

Top GitHub Comments

1reaction

feng-taocommented, Mar 4, 2020

@jinhyukchang agree, @jornh, currently we are a bit behind the schedule, will remove the atlar usage code once we are free up.

Then we could start updating the repo to be py2/py3 compatible. Then only supports py3 once Lyft fully upgrades the airflow infra assuming Lyft is the only one still on py2 at this point…

1reaction

jinhyukchangcommented, Mar 4, 2020

@feng-tao Sounds good to me. May be an announcement of removal is needed for the one that is using it? (Not aware of any though)