Indicator IsVisible Property Nonfunctional

Setting the IsVisible property in the indicator XAML does not have effect, as the IsVisible property is set automatically regardless.

The issue occurs in IndicatorsControl.cs : 217 - ResetVisibility()

Suggestion: Make a private property that respects the XAML state and view models property change notification that ResetVisibility() respects.

Example of Intended Implementation:

                <cards:CarouselView ItemsSource="{Binding ConnectedDevices}" SelectedIndex="{Binding SelectedIndex}" SlideShowDuration="0" IsCyclical="False" VerticalOptions="Start">

                    <cards:CarouselView.ItemTemplate>
                        <DataTemplate>
                            <ContentView>
                                <StackLayout HorizontalOptions="Center" VerticalOptions="Start" Margin="0,0,0,40">
                                    
                                    <!-- Stuff -->
                                </StackLayout>
                            </ContentView>
                        </DataTemplate>

                    </cards:CarouselView.ItemTemplate>

                    <cardcontrols:IndicatorsControl ToFadeDuration="0" Margin="0" VerticalOptions="End" IsVisible="{Binding IndicatorVisible}" />
                    
                </cards:CarouselView>

[InnerScript]

@AndreiMisiukevich

I just got a chance to test the MinimumVisibleIndicatorsCount just now. It is verified.

• When not set, works as previous (regression)
• When set to 2, works as I hoped when opening this issue
• When a second is added to the list at runtime, the indicator appears
• When a second item is removed from the list at runtime, the indicator disappears

Thank you very much for implementing this change so quickly! 👍 👍

[AndreiMisiukevich]

@InnerScript thanks 😃