Pass parameter to viewmodel

Hi, It is actually dagger 2.10 specific question. But I think no problem to ask here. My question is, what if you want to pass RepoView to your RepoViewModel? In my case I am using ViewModel. I am not using LiveData to observe. So I need to pass RepoView to RepoViewModel as parameter.

@Inject
public RepoViewModel(RepoRepository repository, RepoView repoView)

@Module
public class RepoModule {

    @Provides
    RepoView provideRepoView(RepoFragment repoFragment){
        return repoFragment;
    }
}

@ContributesAndroidInjector(modules = RepoModule.class)
    abstract RepoFragment contributeRepoFragment();

I implemented it in this way but it gives me error compile time. It says that I didn’t provide RepoView to inject RepoViewModel. RepoView can not bi provided without @Provides-annotation method. Am I missing something? @JoseAlcerreca @yigit

[JoseAlcerreca]

Don’t pass your view (fragment) to your ViewModel, that’s rule number one of ViewModels 😃 This avoids leaks.

See https://developer.android.com/topic/libraries/architecture/viewmodel.html

Note: Since the ViewModel outlives specific activity and fragment instantiations, it should never reference a View, or any class that may hold a reference to the activity context. If the ViewModel needs the Application context (for example, to find a system service), it can extend the AndroidViewModel class and have a constructor that receives the Application in the constructor (since Application class extends Context).

[yigit]

You should not pass a callback to your ViewModel. If the View is retained, the callback (assuming it references back to the views) will be obsolete.

Instead, your ViewModel can provide observable action events on which your UI can react.