[todo-mvp-dagger] Fragments get constructed twice every time an Activity is restored

The code currently @Injects the StatisticsFragment in StatisticsActivity, which can lead to a very confusing situation when the Activity is restored (configuration change, low memory, etc.):

• Dagger creates a new StatisticsFragment instance and injects it into the field.
• A new, different StatisticsFragment instance gets created and attached by super.onCreate as part of the restore process.
• The code detects that the restored fragment already exists, so it doesn’t use the Dagger-created fragment instance.
• The injected fragment field now contains an unused, unattached fragment.

The fact that StatisticsFragment’s constructor was called twice is also a problem.

A similar situation can occur with the other activities.

[peterholak]

Thanks, but I’m a bit busy right now to take a look at this.

I would probably lean more towards the second option (any DaggerFragment will inject its fields in onAttach anyway), but you might want to ask Dagger authors about which solution they view as the correct one.

[digitalbuddha]

hi @peterholak would you like to take a stab at fixing the fragment injection issue? I see 2 solutions that would work:

1. Change the injection to be Lazy<Fragment> so that we don’t create the fragment until we are sure it did not get restored
2. Remove the injected fragment completely and create it not using dagger as needed.

Since you found the issue I figured I’d give you a chance to get some internet points 😃 If not I’d be happy to fix. Thank you and enjoy your day