Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[FR]: Require/force ktlint/spotless on PRs

See original GitHub issue

Is there an existing issue for this?

I have searched the existing issues

Is this a feature request for one of the samples?

Yes, this is a specific request related to this samples repo.

Sample app

Crane

Describe the problem

We can submit code that fails lint checks 😭

Describe the solution

We could run spotless as part of the build checks and fail when there are issues.

We could also consider ./scripts/gradlew_recursive.sh spotlessApply as a precommit hook or some other way to easily automate this.

Additional context

No response

Code of Conduct

I agree to follow this project’s Code of Conduct

Issue Analytics

State:
Created a year ago
Comments:5 (3 by maintainers)

Top GitHub Comments

2reactions

bentrengrovecommented, May 17, 2022

Narrowed it down further, they are being cancelled as a side effect of https://github.com/android/compose-samples/pull/796

0reactions

riggaroocommented, May 18, 2022

This should fix it - https://github.com/android/compose-samples/pull/814

Top Results From Across the Web

Step by Step: How to setup ktlint with spotless? - SourceLevel

Learn how to set up ktlint using spotless. Amadeu Cavalcante shows step by step how to configure ktlint using Gradle and spotless.

Newest 'ktlint' Questions - Stack Overflow

I have successfully integrated the ktlint with spotless plugin but now I need to ... TaskExecutionException: Execution failed for task ':app:spotlessKotlin'.

Android project code style using Spotless and ktlint - Medium

Improving your code style in just 10 minutes with Spotless and ktlint. ... Now we need to include spotless.gradle in our build —...

diffplug/spotless - build.gradle.kts - Gitter

@nedtwigg sorry for messing with git. You must got tons of mails. ... Unresolved reference: ktlint FAILURE: Build failed with an exception.

Android compose-samples Issues - Giters

[FR]: Fully jetpack compose for JetSurvey. Updated 13 days ago ... Feautue[FR]:. Closed 24 days ago 1 ... [FR]: Require/force ktlint/spotless on PRs....