Add an option in routerLinkActive directive to add "aria-selected=true" attribute

🚀 feature request

Directive routerLinkActive knows when a link is active. Based on that, add “aria-selected=true” attribute to the component.

Relevant Package

This feature request is for @angular/router

Description

Directive routerLinkActive knows when a link is active. Based on that, add “aria-selected=true” attribute to the component.

Describe the solution you’d like

If you have a solution in mind, please describe it.

RouterLinkActive already takes routerLinkActiveOptions as input. We can extend that to support this new feature.

Describe alternatives you’ve considered

Have you considered any alternative solutions or workarounds?

Alternative is to define my own directive based on routerLinkActive, which I may do in the mean time. But I see this as a core accessibility improvement which should be supported natively.

[atscott]

I understand that this is slightly different from the other request. That said, this is pretty trivial to implement in another directive with the new isActivechange event on RouterLinkActive rather than increasing the size, complexity, and behavioral responsibilities of the RouterLinkActive. I don’t think that’s something we should be doing. The directive is nice and focused in its responsibilities at the moment.

On Wed, Sep 15, 2021 at 11:29 AM bm-dev-005 @.***> wrote:

Hi Andrew, I read the other bug. While I agree to most of the decisions. I want to point out that:

• It’s okay for multiple items to have aria-selected=true
• We can introduce this as part of options instead of on by default, which addresses the concerns I think.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/angular/angular/issues/29736#issuecomment-920273309, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADVDYNHETRHUBIVMWRO3S3UCDQYFANCNFSM4HD7HDKQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

–

Andrew Scott | Software Engineer | @.*** | 617-394-8788

[angular-automatic-lock-bot[bot]]

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}