Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Bootstrapping section alludes to referencing services in imports array

See original GitHub issue

I’m submitting a…


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[ ] Feature request
[x] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
[ ] Other... Please describe:

Current behavior

The last paragraph of the “The imports array” section of the docs says:

You don’t have any services to provide yet. But you will create some before long and you may choose to provide many of them here.

Expected behavior

I expect that this line actually belongs in the following section, entitled “The providers array”.

Minimal reproduction of the problem with instructions

Read documentation sections linked above.

What is the motivation / use case for changing the behavior?

Environment


Angular version: 6.0.6-build.45561+sha.aa66e84


Browser:
- [x] Chrome (desktop) version 68.0.3440.106 (Official Build) (64-bit)
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

Issue Analytics

State:
Created 5 years ago
Reactions:1
Comments:5 (3 by maintainers)

Top GitHub Comments

1reaction

kapunahelewongcommented, Sep 17, 2018

Great catch @Lx. Fixed and PR submitted. I decided to remove it altogether because that sentence was in the context of when it was in a larger series of steps in which the reader would add services later. Now it is more of a reference with steps like that being more in line with the Tour of Heroes. Good eye! 😃

EDIT: Thanks for tagging me so I could fix it right away 😃

1reaction

Lxcommented, Sep 16, 2018

My suspicion is correct—this paragraph originally appeared under “The providers array”. It was erroneously moved to a different section in commit https://github.com/angular/angular/commit/53f91189a12ee214d7314ea73ce138dcdb1333c8 by @kapunahelewong:

https://github.com/angular/angular/commit/53f91189a12ee214d7314ea73ce138dcdb1333c8:#diff-036e0d00ef7828a090b995fb5e8a51bfL110

Top Results From Across the Web

Bootstrapping - Angular - w3resource

bootstrapping, refers to the initial piece of code that is executed upon startup. ... Only @NgModule references go to the imports array.

Bootstrapping an Application in Angular - Pluralsight

Apart from the app-level component, this module also has reference to all external modules imported using the imports array.

Entry components - Angular

A bootstrapped component is an entry component that Angular loads into the DOM during the bootstrap process (application launch). Other entry components are ......

Bootstrapping - Tutorial - Vskills

The module's imports array appears exclusively in the @NgModule metadata object. It tells Angular about other NgModules that this particular module needs to ......

Angular 4 - Module - Tutorialspoint

It starts with @NgModule and contains an object which has declarations, import s, providers and bootstrap. Declaration. It is an array of components...