Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Build Optimizer too aggressive, breaking some of our application code

See original GitHub issue

Versions

1.5.0 (ejected configuration)

Repro steps

Include in module.rules:

                {
                    test: /(\.ngfactory\.js|\.ngstyle\.js|\.ts)$/,
                    use: [
                        {
                            loader: '@angular-devkit/build-optimizer/webpack-loader',
                            options: {
                                sourceMap: true
                            }
                        },
                        '@ngtools/webpack'
                    ]
                },

Step 2: Write code in a method for a component like this:

private instrumentCreateMenuImpression() {
        const params: InstrumentationParams = {};
        params[InstrumentationParam.ItemCount] = this.items ? this.items.length.toString() : '0';
        params[InstrumentationParam.RenderSize] = this.createLinks ? this.createLinks.length.toString() : '0';
        params[InstrumentationParam.Distribution] = this.createLinks
            ? this.createLinks.map(link => link.workload.Id).reduce((prevVal, currVal, index) => prevVal + (index === 0 ? '' : ';') + currVal, '')
            : '';

        const metrics = [
            KnownInstrumentationEvents.CreateMenuImpression,
            `${KnownInstrumentationEvents.CreateMenuImpression}.${this.createLinks.length}`
        ];
        this.instrumentationService.generateImpressionEvent(KnownInstrumentationEvents.CreateMenuImpression, null, params, metrics).record();
}

Step 3: Observe build optimizer output:

CreateMenuComponent.prototype.instrumentCreateMenuImpression = function () {
    var params = /*@__PURE__*/ (function () {
            var params = {};
            params[instrumentation_service["a" /* InstrumentationParam */].ItemCount] = this.items ? this.items.length.toString() : '0';
            params[instrumentation_service["a" /* InstrumentationParam */].RenderSize] = this.createLinks ? this.createLinks.length.toString() : '0';
            params[instrumentation_service["a" /* InstrumentationParam */].Distribution] = this.createLinks
                ? this.createLinks.map(function (link) { return link.workload.Id; }).reduce(function (prevVal, currVal, index) { return prevVal + (index === 0 ? '' : ';') + currVal; }, '')
                : '';
            return params;
        })();
        var metrics = [
            instrumentation_service["e" /* KnownInstrumentationEvents */].CreateMenuImpression,
            instrumentation_service["e" /* KnownInstrumentationEvents */].CreateMenuImpression + "." + this.createLinks.length
        ];
        this.instrumentationService.generateImpressionEvent(instrumentation_service["e" /* KnownInstrumentationEvents */].CreateMenuImpression, null, params, metrics).record();
}