DI - Handle the "InjectFlags" in Injector_.get()

🚀 feature request

Relevant Package

This feature request is for @angular/core

Description

At the moment the Injector_.get() implementation doesn’t handle the InjectFlags. I’d like the feature so that I can use the component Injector like this:

@Component(...)
export class SomeComponent {
    // Here I get an instance of Injector_
    constructor(injector: Injector) {
        this.myService = injector.get(SomeService, null, InjectFlags.SkipSelf);
    }
}

Describe the solution you’d like

It looks like you already handle the DeepFlags. refs.ts:342
You probably just need to map and pass the InjectFlags to the resolveDeep() function

class Injector_ implements Injector {
  ...
  get(token: any, notFoundValue: any = Injector.THROW_IF_NOT_FOUND): any {
    ...
    return Services.resolveDep(
        this.view, this.elDef, allowPrivateServices,
        {flags: DepFlags.None, token, tokenKey: tokenKey(token)}, notFoundValue);
  }
}

I don’t think I have enough knowledge of the project to submit a PR by myself, so I’m relying on you for this.
Thanks in advance for your work

[kpeterbauer]

I would call it a bug, not a feature: The provided Injector clearly does not behave as defined by the API documentation:

https://angular.io/api/core/Injector

[stupidawesome]

NodeInjector isn’t passing the flag here di.ts#L628

export class NodeInjector implements Injector {
  constructor(
      private _tNode: TElementNode|TContainerNode|TElementContainerNode|null,
      private _lView: LView) {}

  get(token: any, notFoundValue?: any): any {
    return getOrCreateInjectable(this._tNode, this._lView, token, undefined, notFoundValue);
  }
}