hasValidator "@angular/forms": "12.2.5" not working

Which @angular/* package(s) are the source of the bug?

forms

Is this a regression?

No

Description

in unit test, I want to check validators in form control

this.userForm = this.formBuilder.group({
      orgId: null,
      name: [null, [Validators.required, Validators.minLength(3), Validators.maxLength(30)],
        [specialCharAsyncValidator(this.infoService)]
      ],
....
get orgIdCtrl(): AbstractControl { return this.userForm.get('orgId'); }
get nameCtrl(): AbstractControl { return this.userForm.get('name'); }

it('form control check for validators', () => {

    expect(component.orgIdCtrl.hasValidator(Validators.required)).toBeFalse();

    const nameCtrl = component.nameCtrl;
    expect(nameCtrl.hasValidator(Validators.required)).toBeTruthy(); // OK
    expect(nameCtrl.hasValidator(Validators.minLength(3))).toBeTruthy(); // it is false, so NOT OK
    expect(nameCtrl.hasValidator(Validators.maxLength(30))).toBeTruthy(); // it is false, so NOT OK
    expect(nameCtrl.hasAsyncValidator(specialCharAsyncValidator(infoService))).toBeTruthy(); // it is false, so NOT OK

  });

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

1) form control check for validators
     testing AddComponent
     Error: Expected false to be truthy.
    at <Jasmine>
    at UserContext.<anonymous> (src/app/components/user-add/add/add.component.spec.ts:86:60)

Please provide the environment you discovered this bug in

❯ ng version

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 12.2.5
Node: 14.15.4
Package Manager: npm 6.14.10
OS: win32 x64

Angular: 12.2.5
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, localize, platform-browser
... platform-browser-dynamic, router, service-worker

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1202.5
@angular-devkit/build-angular   12.2.5
@angular-devkit/core            12.2.5
@angular-devkit/schematics      12.2.5
@schematics/angular             12.2.5
rxjs                            7.3.0
typescript                      4.3.5

Anything else?

No response

[jnizet]

If I try to reproduce the issue (with a validator stored as in instance variable of the component), I can’t: the test passes as I expected. See https://github.com/jnizet/has-validator-repro.

@sysmat My test passes, so my guess is that yours fails for a different reason. But IMHO, this is not the best way to test your component anyway: testing that a control has a validator min3, which could be… any validator, doesn’t really test a requirement. IMHO, it would be best to treat the component as a black box and write the test as an end user would test it:

• fill the input with 2 characters
• check that an error is displayed informing that the field must contain at least 3 characters
• fill the input with 3 characters
• check that the error disappears

[angular-automatic-lock-bot[bot]]

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}