Improve how AoT compiler casts to boolean

I’m submitting a … (check one with “x”)

[x] bug report => search github for a similar issue or PR before submitting

Current behavior

During ngc compilation, I get several errors of the type:

Type 'IDrillActive' is not assignable to type 'boolean'.

As the compiler parses auto-generated code:

const currVal_0:boolean = (!this.context.store.appState.loading && this.context.drill);

These errors from .ngfactory.ts files clutter the IDE and make it tougher to spot errors in my own code.

Expected behavior

I think it would be better to properly cast expressions to booleans. For instance the line above could be re-factored to:

const currVal_0:boolean = !!(!this.context.store.appState.loading && this.context.drill);

What is the motivation / use case for changing the behavior?

To reduce compiler errors generated by .ngfactory.ts files

Please tell us about your environment:

• Angular version: 2.0.0-rc.6
• Browser: [all]
• Language: [TypeScript 2.0.2]
• Node (for AoT issues): node --version = 4.5.0

[RoxKilly]

@vvakame the problem is with our code, not Angular.

!loggedIn && loginURL

This resolves to a string because the 2nd operand is a string. If you don’t want to see these errors, you need to adjust your conditional statements to return booleans, not just truthey values. For instance you could do:

loginURL && !loggedIn

Typescript resolves this to a boolean (the type of the last operand) so you won’t see the error.

Alternatively, you could force your non-booleans into booleans with the !! prefix:

!loggedIn && !!loginURL

[angular-automatic-lock-bot[bot]]

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}