question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Ivy: Remove entryComponents property from @NgModule decorator in @angular/core migrations

See original GitHub issue

🚀 feature request

Relevant Package

This feature request is for @angular/core

The relevant migrations are currently located at: https://github.com/angular/angular/tree/master/packages/core/schematics/migrations

Description

Updating to Angular version 9 performs several post-install migrations using schematics. These are incredible, and very much appreciated. ❤️

This feature request is to add an additional migration when updating to Angular v9 using the ng update command to remove the entryComponents property in all @NgModule() decorators since the code is unnecessary after updating to Angular version 9 with Ivy.

Describe the solution you’d like

Remove entryComponents property in @NgModule() decorators using schematics.

Describe alternatives you’ve considered

Alternative include:

  1. Manually remove entryComponents after updating.
  2. Leave the entryComponents after updating since it does not cause an errors or side effects.
  3. Create a schematic separate from the @angular/core module to perform the migration for those that desire this functionality.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:7
  • Comments:8 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
JoostKcommented, May 26, 2022

Implemented in #44322.

0reactions
angular-automatic-lock-bot[bot]commented, Jun 26, 2022

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Angular Update Guide
In your application projects, you can remove entryComponents NgModules and any uses of ANALYZE_FOR_ENTRY_COMPONENTS . They are no longer required with the ...
Read more >
Why entryComponents is not necessary ... - Stack Overflow
Ivy introduced a completely new ngtsc compiler which mental model is that the decorator is the compiler. In other words, the overall ...
Read more >
Angular Revisited: Standalone components and optional ...
In a future version of Angular, Ivy will enable us to bootstrap or render components to the DOM without any Angular modules. We...
Read more >
Angular 9 Update Guide | Brian F Love
Remove unnecessary entryComponents properties in our @NgModule() decorators object. Migrate to TestBed.inject(). Post the Angular version 9 ...
Read more >
Migrating to Angular 9: Tales of a piece of cake… - Medium
to the Angular Team for baking us a very nice migration from 8 to 9. ... removed all the entryComponents property occurrences in...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found