[Ivy] @ViewChild doesn't read me ElementRef

🐞 bug report

Affected Package

The issue is caused by package @angular/core

Is this a regression?

Maybe, it seems to be available if we read this status

Description

I’m testing Ivy on a little application with the beta.3 but I have a component like this:

@Component({
    selector: 'tracklist',
    templateUrl: './tracklist.component.html',
    styleUrls: ['./tracklist.component.css'],
    changeDetection: ChangeDetectionStrategy.OnPush
})
export class TracklistComponent implements AfterViewInit {
...
    @ViewChild('matTable', {read: ElementRef}) elRef;

constructor(private route: ActivatedRoute, private renderer: Renderer2) { }


ngAfterViewInit() {
...
  this.renderer.setStyle(this.elRef.nativeElement, 'overflow-y', 'hidden');
}

When I run ng serve --aot and I instantiate this component, I have this error:

Error TypeError : Cannot read property 'nativeElement' of undefined

elRef is always undefined.

🌍 Your Environment

Angular Version:

Angular CLI: 7.2.4
Node: 10.10.0
OS: darwin x64
Angular: 8.0.0-beta.3
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, platform-server, router
... service-worker

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.12.4
@angular-devkit/build-angular     0.12.4
@angular-devkit/build-optimizer   0.12.4
@angular-devkit/build-webpack     0.12.4
@angular-devkit/core              7.2.4
@angular-devkit/schematics        7.2.4
@angular/cdk                      7.3.1
@angular/cli                      7.2.4
@angular/material                 7.3.1
@ngtools/webpack                  7.2.4
@schematics/angular               7.2.4
@schematics/update                0.12.4
rxjs                              6.3.3
typescript                        3.2.4
webpack                           4.28.4

[gkalpak]

FYI: I just run in the inheritance issue myself and working on a fix for ngcc.

[alexzuza]

@wKoza Thank you for the repo.

You’re right that the error Cannot read property 'toArray' of undefined at mergeQueryListAndSet can’t be seen with OnPush since that error is eaten by this code.

https://github.com/angular/angular/blob/81329c85b3194d3ee1b3614b6349edc6c2fd6a60/packages/core/src/render3/instructions.ts#L2826-L2834

And you are also right that the error has something to do with ngcc.

It doesn’t generate features: [InheritDefinitionFeature] for component definitions like MatTable, CdkRowDef, etc.

cc: @petebacondarwin