KeyEventPlugin forces event handler in `ngZone`, the behavior is different with non key event handler.

Consider the following case.

app.component.html

<button #btnToggle>Toggle</button>
<div *ngIf="show">
  <button (click)="onClick()">Button</button>
  <input (keydown.enter)="onKeydown()"/>
</div>

app.component.ts

export class AppComponent implements AfterViewInit {
    @ViewChild('btnToggle') btnToggle: ElementRef;
    show = false;
    constructor(private zone: NgZone, private cd: ChangeDetectorRef) {}

    ngAfterViewInit() {
      this.zone.runOutsideAngular(() => {
        const el = this.btnToggle.nativeElement as HTMLElement;
        el.addEventListener('click', e => {
          this.show = true;
          this.cd.detectChanges();
        })
      })
   }

   onClick() {
      console.log('button click in ngZone? ', NgZone.isInAngularZone());
   }

   onKeydown() {
      console.log('keydown in ngZone? ', NgZone.isInAngularZone());
    }
}

The live sample is here https://stackblitz.com/edit/angular-hga7lk?file=src%2Fapp%2Fapp.component.ts

After click the toggle button, then click the inside button and press enter inside the input. The output will be:

button click in ngZone?  false
keyDown in ngZone? true

This is not consistent

[JiaLiPassion]

@artaommahe , I totally understand your concerns and agree with your point, but this issue and related PR doesn’t introduce a new behavior. The current behavior (except the events like keydown.enter) is outside ngZone.

<button #btnToggle>Toggle</button>
<div *ngIf="show">
  <button (click)="onClick()">Button</button>
  <input (keydown.enter)="onKeydown()"/>
</div>

In this case, the current behavior is

1. the button click is outside of ngZone.
2. the keydown is inside ngZone.

Which is not consistent. And most cases are like button click, so this issue and PR just make keydown.enter behaves the same way as button click.

Of course we can discuss this behavior is correct/confuse or not in another issue.

[angular-automatic-lock-bot[bot]]

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}