Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Merge PR script doesn't take into account Code Owners approval status

See original GitHub issue

The merge-pr script that is actively used by Caretakers doesn’t take Code Owners approval status into account. I.e. it’s possible to merge a PR without all the necessary approvals. It looks like NG Bot should take care of this situation (similar to what we used to have with PullApprove integration).

cc @ocombe @kara

Issue Analytics

State:
Created 5 years ago
Reactions:1
Comments:8 (7 by maintainers)

Top GitHub Comments

1reaction

ajitsinghkalercommented, Mar 9, 2020

@gkalpak @AndrewKushnir I think this issue has been solved after pull Approve

0reactions

angular-automatic-lock-bot[bot]commented, Apr 9, 2020

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

Top Results From Across the Web

Allow "code owners" to merge PRs for individual typings #18449

Is it acceptable for a PR to merge (assuming CI is ✔️ ) as soon as an owner approves? I would prefer rules...

Code Owners - GitLab Docs

You can set your merge requests so they must be approved by Code Owners before merge. You can protect a branch and allow...

Configuration Options - Renovate Docs

By default, Renovate will not assign reviewers and assignees to an automerge-enabled PR unless it fails status checks. By configuring this setting to...

Code Owners for Bitbucket - Confluence - Mibex Software JIRA

In case a Code Owner is absent and the PR can not be merged because of a missing Code Owner approval, add extra...

Git branch policies and settings - Azure Repos - Microsoft Learn

This setting requires that work items be linked to a PR for the PR to merge. Make the setting Optional to warn when...