Migrating to v8 changes ViewChild to VViewChild

Description

This might be connected to angular/angular-cli#14551 and angular/angular-cli#9712

After I ran the migration, all my ViewChild references turned into VViewChild.

Edit: I just noticed that this only happened to the files with UTF-8 encoding. The files encoded with UTF-8 BOM are good.

[alan-agius4]

@devversion I think this discussion should be moved in a new issue in the CLI repo.

[alan-agius4]

As discussed offline, the problem/feature is indeed in the CLI because the updateRecorder methods such as insertLeft, remove etc… accepts positions which are not offset by a BOM. This is because when a file has a BOM a different recorder will be used https://github.com/angular/angular-cli/blob/master/packages/angular_devkit/schematics/src/tree/recorder.ts#L72 which caters for an addition offset/delta.

The main reason for this is that when a developer is writing a schematic they shouldn’t need to compute the offset based if a file has a BOM or not and is handled out of the box.

Example

recorder.insertLeft(5, 'true');

However this is unfortunate in the case if a ts SourceFile is used and one uses getWidth and getStart method they will already be offset by 1, which at the end it results in a double offset and hence the problem.