NGCC Error: Node does not exist

🐞 bug report

Affected Package

@angular/compiler-cli

Is this a regression?

No

Description

Node does not exist error is thrown by NGCC when a direct or transitive dependency of a module that is being processed is missing.

For example in the reproduction, when trying to process @angular/material/progress-bar it is failing, because this depends on @angular/material/core, and the later on @angular/cdk. But @angular/cdk is not installed.

The error itself is not self explanatory and might send users on a goose chase. Hence, we should handle missing dependencies more gracefully and hint the users which is the missing dependency.

🔬 Minimal Reproduction

https://github.com/alan-agius4/ngcc-node-error/tree/master

🔥 Exception or Error

throw new Error('Node does not exist: ' + node);
      ^
Error: Node does not exist: /workspace/ngcc-node-error/node_modules/@angular/material/progress-bar
    at DepGraph.dependenciesOf (/workspace/ngcc-node-error/node_modules/dependency-graph/lib/dep_graph.js:187:13)
    at DependencyResolver.sortEntryPointsByDependency (/workspace/ngcc-node-error/node_modules/@angular/compiler-cli/ngcc/src/packages/dependency_resolver.js:42:47)
    at EntryPointFinder.findEntryPoints (/workspace/ngcc-node-error/node_modules/@angular/compiler-cli/ngcc/src/packages/entry_point_finder.js:37:34)
    at Object.mainNgcc [as process] (/workspace/ngcc-node-error/node_modules/@angular/compiler-cli/ngcc/src/main.js:50:34)
    at Object.<anonymous> (/workspace/ngcc-node-error/index.js:4:6)
    at Module._compile (module.js:653:30)
    at Object.Module._extensions..js (module.js:664:10)
    at Module.load (module.js:566:32)
    at tryModuleLoad (module.js:506:12)
    at Function.Module._load (module.js:498:3)
npm ERR! Test failed.  See above for more details.

🌍 Your Environment

Angular Version:

8.0.0-beta.10

[qaxqaxqax]

I have got the same issue with ngx-highlightjs:

ERROR in Node does not exist: /Users/localadmin/D/restructure/webclients/node_modules/ngx-highlightjs

(8.2.0-rc.0)

[petebacondarwin]

We should handle this better. There is logic in ngcc to cope with this but it is obviously not working correctly in this case.