Objects converted to ParamMap can err when ParamMap functions are called on them.

🐞 bug report

Affected Package

Error is in the Router module’s shared.ts file, on line 68. https://github.com/angular/angular/blob/79fb9d449c0fab9bdb5886f09d4fc9cd52f89318/packages/router/src/shared.ts#L68

Description

If an object is passed to the convertToParamMap function is missing the hasOwnProperty method. Attempts to call the new ParamsAsMap object’s has, get, or getAll methods will all throw this error: TypeError: this.params.hasOwnProperty is not a function.

🔬 Minimal Reproduction

https://stackblitz.com/edit/angular-igb464?embed=1&file=src/app/app.component.ts

🔥 Exception or Error

TypeError: this.params.hasOwnProperty is not a function

🌍 Your Environment

Angular Version:

Angular CLI: 6.0.8
Node: 10.1.0
OS: win32 x64
Angular:
...

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.6.8
@angular-devkit/core         0.6.8
@angular-devkit/schematics   0.6.8
@schematics/angular          0.6.8
@schematics/update           0.6.8
rxjs                         6.2.2
typescript                   2.7.2

Anything else relevant? I’m pretty sure this occurred because I created the initial Params object using Object.create(null). At the time, I wanted a very plain object with no extraneous stuff on its prototype chain.

[abarghoud]

@jasonaden PR ready for a review

[angular-automatic-lock-bot[bot]]

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}