OnDestroy override issue - Angular 9+

🐞 bug report

Affected Package

The issue is caused by package **@angular/core**

Is this a regression?

Yes, the previous version in which this bug was not present was: **Angular 8**

Description

Consider a @Component what implements OnDestroy, on the constructor there is a case I must set the following code:

this.OnDestroy = ()=>{ alert(‘Invoke’); }

On Angular 8, it use to work, but somehow in Angular 9 (maybe its IVE issue) that not entering to the override func, instead it entering to the initial implemented func.

Can you explain why and if it really a bug?

🌍 Your Environment

Angular Version:

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.901.6
@angular-devkit/core         9.1.6
@angular-devkit/schematics   9.1.6
@schematics/angular          9.1.6
@schematics/update           0.901.6
rxjs                         6.5.4

[petebacondarwin]

This is kind of a duplicate of https://github.com/angular/angular/issues/30497, which is fixed by https://github.com/angular/angular/pull/35464. But in your case, you appear to be changing the onDestroy() method on the instance, whereas that PR will only allow you to change the method on the prototype.

I think you could workaround this right now by creating your class like:

@Component(...)
export class MyComponent implements NgOnDestroy {
  onDestroy() {
    this._onDestroy();
  }

  private _onDestroy() {}

  constructor() {
    this._onDestroy = () => {
      alert('Invoke');
    };
  }
}

[angular-automatic-lock-bot[bot]]

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}