package.json in guide/elements download
See original GitHub issue📚 Docs or angular.io bug report
Description
In the guide about angular/elements there is an example, the issue is related to the code available for download in the end of the session https://angular.io/guide/elements#example-a-popup-service.
While the code itself works, the package.json needs to be updated.
🔬 Minimal Reproduction
- Download the code from the the link int the page, pointing to https://angular.io/generated/zips/elements/elements.zip.
- Extract the zip in a new folder.
- npm install
- ng serve
The package @angular/elements is missing.
the package
"angular-in-memory-web-api": "github:brandonroberts/in-memory-web-api-bazel#50a34d8"
require versions < 8.0.0 of some angular packages, it seems that in the mean time the package was added to npm, and now it can be changed to
"angular-in-memory-web-api": "0.8.0"
What’s the affected URL?**
https://angular.io/guide/elementsI have noticed a comment in the github source about needing polyfills but in the page it was not clear if any additional step would be required after downloading. Since it is a guide it is supposed to be followed by beginners, and I believed it was something that worth to report.
Issue Analytics
- State:
- Created 4 years ago
- Comments:11 (6 by maintainers)
Top GitHub Comments
Can I take a stab at the
@angular/elements
dependency fix. The explanation given by @gkalpak of what needs to be done seems clear and I would love to do this as my first open source contribution, as well as for Hacktoberfest 😄@gkalpak @kapunahelewong ok, great. working on it