question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Performance issue

See original GitHub issue

Which @angular/* package(s) are the source of the bug?

animations

Is this a regression?

No

Description

When doing some performance debugging in our application I noticed that around 1/3 of the time to process our components is used by a single function related to animations.

https://github.com/angular/angular/blob/4c778cdb28de128c6ddecd2fd6cb6257d675500b/packages/animations/browser/src/render/transition_animation_engine.ts#L855

If you look at my performance profile you can see that the anonymous function marked in red (and the ones next to it) is calling _balanceNamespaceList and it takes almost a third of the total processing for rendering the layout. image

Is it supposed to be like this? Can it be optimized? Or can be disable something so it doesn’t do this without removing all animations?

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

No response

Please provide the environment you discovered this bug in (run ng version)

Angular CLI: 13.2.1
Node: 16.14.0
Package Manager: npm 8.3.1
OS: win32 x64

Angular: 13.2.1
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, material, platform-browser, platform-browser-dynamic
... router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.1302.1
@angular-devkit/build-optimizer   0.1302.1
@angular-devkit/core              13.2.1
@angular-devkit/schematics        13.2.1
@ngtools/webpack                  13.2.1
@schematics/angular               13.2.1
ng-packagr                        13.2.1
rxjs                              7.5.2
typescript                        4.5.5
webpack                           5.67.0

Anything else?

No response

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:20 (16 by maintainers)

github_iconTop GitHub Comments

4reactions
JoostKcommented, Feb 11, 2022

I work on Angular in my spare time, so that includes weekends 😉 But no hurry from my side, you’re fine to follow up whenever fits you (please do take weekends off, haha).

2reactions
JonWallstencommented, Feb 12, 2022

@JonWallsten: It seems like it went from 1.5 seconds to 5 milliseconds (!) How do I verify that everything is correct? I’m not sure what the code does? image

Read more comments on GitHub >

github_iconTop Results From Across the Web

Handling Performance Issues With Grace | Monster.com
Low Productivity or Late Completion – Make sure you've been clear about the requirements and expectations of the job. · Poor Quality of...
Read more >
9 Examples of a Performance Issue - Simplicable Guide
A performance issue is a failure to meet the basic requirements of a job. They are based on reasonable expectations of behavior and...
Read more >
Top 5 Common Performance Problems - HRCI
Top 5 Common Performance Problems · Shallow Work · Inability to Prioritize · False Sense of Urgency · Productive Procrastination · Low-Quality Output....
Read more >
5 Common Reasons for Performance Issues (Plus 3 Tips to ...
Most Common Causes of Performance Issues · 1. They lack knowledge or skill. · 2. They have unclear or unrealistic expectations. · 3....
Read more >
5 Best Practices for Managing Employee Performance Issues
Discussing performance issues with employees shouldn't be restricted to ... Addressing the issue when it starts is the most sure-fire way to ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found