`processNewMacroTasksSynchronously: false` does not work well with rxjs' timer and interval functions

🐞 bug report

Affected Package

The issue is caused by package @angular/angular/core/testing

Is this a regression?

No

Description

Using tick(0, { processNewMacroTasksSynchronously: false }) with rxjs’ timer and interval does not worked as expected.

🔬 Minimal Reproduction

Example with timer, callback never been called

it('with timer', fakeAsync(() => {
  const callback = jasmine.createSpy('callback');

  timer(0, 0).pipe(skip(1), take(1)).subscribe(callback);

  expect(callback).not.toHaveBeenCalled();

  tick(undefined, { processNewMacroTasksSynchronously: false });

  expect(callback).not.toHaveBeenCalled();

  tick(undefined, { processNewMacroTasksSynchronously: false });

  expect(callback).toHaveBeenCalledTimes(1);
}));

Same with interval, code in test file. Repo with this test

• git clone [e-mail]:artaommahe/tick-with-timer-and-interval.git
• yarn install
• yarn test

test file

Even using tick() does not work here.

🔥 Exception or Error

Chrome 83.0.4103.106 (Windows 10) tickWithTimerAndInterval with timer FAILED
        Error: Expected spy callback to have been called once. It was called 0 times.
            at <Jasmine>
            at UserContext.<anonymous> (http://localhost:9876/_karma_webpack_/src/app/tickWithTimerAndInterval.spec.ts:24:22)

🌍 Your Environment

Angular Version:

Angular CLI: 10.0.0-rc.5
Node: 12.18.1
OS: win32 x64

Angular: 10.0.0-rc.6
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.1000.0-rc.5
@angular-devkit/build-angular     0.1000.0-rc.5
@angular-devkit/build-optimizer   0.1000.0-rc.5
@angular-devkit/build-webpack     0.1000.0-rc.5
@angular-devkit/core              10.0.0-rc.5
@angular-devkit/schematics        10.0.0-rc.5
@angular/cli                      10.0.0-rc.5
@ngtools/webpack                  10.0.0-rc.5
@schematics/angular               10.0.0-rc.5
@schematics/update                0.1000.0-rc.5
rxjs                              6.5.5
typescript                        3.9.5
webpack                           4.43.0

Anything else relevant?

Same case works well with jest fake timers

const callback = jest.fn();
jest.useFakeTimers();

timer(0, 0).pipe(skip(1), take(1)).subscribe(callback);

expect(callback).not.toHaveBeenCalled();

jest.runOnlyPendingTimers();

expect(callback).not.toHaveBeenCalled();

jest.runOnlyPendingTimers();

expect(callback).toBeCalledTimes(1);

[JiaLiPassion]

yes, just like you said, jest.runOnlyPendingTimers() is different with tick(x, {processNewMacroTAsksSynchronously: false}), since tick has a advancedTime parameter.

And interval(0) behave differently with timer(0,0) since setInterval allow to pass an zero interval. So when you tick, the interval will be triggered twice and cause skip and take to be triggered too.

And also, here use processNewMacroTasksSynchronously: false will not work either since fakeAsync will always handle interval calls in the current tick. So if you have some use case need this case work as spy not called, please tell me and we can discuss about it.

Thanks.

[angular-automatic-lock-bot[bot]]

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}