Re-navigating to a the same url during an active navigation causes cancellation without a new navigation starting

🐞 bug report

Affected Package

@angular/router

Is this a regression?

No

Description

While the router is in the route activation phase if it receives another navigation request that results in the same url the active navigation will be canceled, but the new navigation won’t start. This only occurs when onSameUrlNavigation=false (the default). I would expect that a NavigationEnd event would be emitted for either the first or replacement navigation, but currently one is never emitted.

🔬 Minimal Reproduction

https://angular-fz4k5d.stackblitz.io Click the “Test” link to navigate to navigate to /test?query=someText

NavigationStart {id: 1, url: "/", navigationTrigger: "imperative", restoredState: null}
RoutesRecognized {id: 1, url: "/", urlAfterRedirects: "/404", state: RouterStateSnapshot}
GuardsCheckStart {id: 1, url: "/", urlAfterRedirects: "/404", state: RouterStateSnapshot}
ChildActivationStart {snapshot: ActivatedRouteSnapshot}
ActivationStart {snapshot: ActivatedRouteSnapshot}
GuardsCheckEnd {id: 1, url: "/", urlAfterRedirects: "/404", state: RouterStateSnapshot, shouldActivate: true}
ResolveStart {id: 1, url: "/", urlAfterRedirects: "/404", state: RouterStateSnapshot}
ResolveEnd {id: 1, url: "/", urlAfterRedirects: "/404", state: RouterStateSnapshot}
ActivationEnd {snapshot: ActivatedRouteSnapshot}
ChildActivationEnd {snapshot: ActivatedRouteSnapshot}
NavigationEnd {id: 1, url: "/", urlAfterRedirects: "/404"}
Scroll {routerEvent: NavigationEnd, position: null, anchor: null

### Click test link
NavigationStart {id: 2, url: "/test?query=someText", navigationTrigger: "imperative", restoredState: null}
RoutesRecognized {id: 2, url: "/test?query=someText", urlAfterRedirects: "/test?query=someText", state: RouterStateSnapshot}
GuardsCheckStart {id: 2, url: "/test?query=someText", urlAfterRedirects: "/test?query=someText", state: RouterStateSnapshot}
ChildActivationStart {snapshot: ActivatedRouteSnapshot}
ActivationStart {snapshot: ActivatedRouteSnapshot}
GuardsCheckEnd {id: 2, url: "/test?query=someText", urlAfterRedirects: "/test?query=someText", state: RouterStateSnapshot, shouldActivate: true}
ResolveStart {id: 2, url: "/test?query=someText", urlAfterRedirects: "/test?query=someText", state: RouterStateSnapshot}
ResolveEnd {id: 2, url: "/test?query=someText", urlAfterRedirects: "/test?query=someText", state: RouterStateSnapshot}

### navigate from component constructor loaded through route activation triggers previous navigation to cancel
### This navigation is also to /test?query=someText
NavigationCancel {id: 2, url: "/test?query=someText", reason: "Navigation ID 2 is not equal to the current navigation id 3"}

### I think these are left over from id=2
ActivationEnd {snapshot: ActivatedRouteSnapshot}
ChildActivationEnd {snapshot: ActivatedRouteSnapshot}

### No NavigationEnd event fires for navigating to /test?query=someText (for id=2 nor id=3)
### No Navigation events fire for id=3

🌍 Your Environment

Angular Version: 8.2.14

[YogliB]

This is still happening on Angular@10, when re-navigation is triggered from inside of a Guard.

[zhengsansan]

这个问题有解决方案吗？ 原因分析： 经过跟踪代码，我发现是因为在组件ngOnDestroy的时候重复调用了一次路由跳转的方法，然而this.router.navigate每执行一次navigationId就会+1，这样就造成了navigationId不匹配，路由事件被取消； 解决办法： 删除组件中ngOnDestroy里重复调用navigate的方法，问题解决之。同理，其它类似的问题也因该是路由的重复调用引起的，建议大家仔细排查代码，删除重复的里有调用即可。