requiredTrue doesn't set a control to be `INVALID` when its value is not `true`

See comment thread

🐞 bug report

Affected Package

The issue is caused by package @angular/....

“@angular/forms”: “^8.0.2”

Is this a regression?

Not sure

Description

I change validation rules on fly by setting Validators.requriedTrue however the control which has whatever value but true is still valid and my form is ready to submit (meanwhile it shouldn’t).

I use this.formGroup.get(...).setValidators(Validators.requiredTrue). The validator is set, but form is still valid although the value of the control is null or false

A clear and concise description of the problem...

🔬 Minimal Reproduction

https://stackblitz.com/edit/angular-wrokpb

Click the button to toggle the requiredTrue and see in console logged FormGroup object.

🔥 Exception or Error

🌍 Your Environment

Angular Version:

Angular CLI: 8.0.4
Node: 12.5.0
OS: linux x64
Angular: 8.0.2
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.800.4
@angular-devkit/build-angular      0.800.4
@angular-devkit/build-ng-packagr   0.800.4
@angular-devkit/build-optimizer    0.800.4
@angular-devkit/build-webpack      0.800.4
@angular-devkit/core               8.0.4
@angular-devkit/schematics         8.0.4
@angular/cdk                       8.0.1
@angular/cli                       8.0.4
@angular/material                  8.0.1
@angular/material-moment-adapter   8.0.1
@ngtools/json-schema               1.1.0
@ngtools/webpack                   8.0.4
@schematics/angular                8.0.4
@schematics/update                 0.800.4
ng-packagr                         5.3.0
rxjs                               6.5.2
typescript                         3.4.5
webpack                            4.30.0

Anything else relevant?

[jasonaden]

You’re correct, this should be noted in the docs for setValidators. I’m moving this to a docs issue.

[angular-automatic-lock-bot[bot]]

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}