tsickle is not installed by default in 7.0.0-rc.0
See original GitHub issueI’m submitting a…
[X] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
[ ] Other... Please describe:
Current behavior
Noticed a breaking change when updating a simple app from 6.1.x to 7.0.0-rc.0 and trying to bundle our applications with closure compiler.
tsickle is not installed when running npm install
on typical angular packages.
Expected behavior
tsickle is installed by @angular
packages like before.
Minimal reproduction of the problem with instructions
npm install -g @angular/cli@latest angular-rollup@latest
ngr new my-app
<-- you are generating a new app with ngr instead of ng
Update angular packages to 7.0.0-rc.0 and typescript to 3.1.1
ngr build prod --serve
Notice in terminal error about tsickle
module is missing
: Error: Cannot find module 'tsickle'
at Function.Module._resolveFilename (module.js:555:15)
at Function.Module._load (module.js:482:25)
at Module.require (module.js:604:17)
at require (internal/module.js:11:18)
npm install tsickle
Error is gone.
- NOTE there is separate issue preventing closure compiler from bundling because of new dependence on
@angular/compiler
in@angular/core
package.
If you add below to the closure.conf the build will now work.
--js node_modules/@angular/compiler/package.json
--js node_modules/@angular/compiler/fesm2015/compiler.js
What is the motivation / use case for changing the behavior?
Maintenance of tsickle version is now on application team and is no longer in sync with compiler.
Environment
Angular version: 7.0.0-rc.0
Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
For Tooling issues:
- Node version: v9.5.0
- Platform: MacOS
Others:
Issue Analytics
- State:
- Created 5 years ago
- Reactions:4
- Comments:9 (5 by maintainers)
Top Results From Across the Web
tsickle - npm
Start using tsickle in your project by running `npm i tsickle`. There are 208 other projects in the npm registry using tsickle.
Read more >npm WARN ... requires a peer of ... but none is installed. You ...
"A requires a peer of B but none was installed". Consider it as "A requires one of B's peers but that peer was...
Read more >ng-packagr/CHANGELOG.md - UNPKG
7. 8, ### Bug Fixes ... In less v3 is supports node_modules resolutions by default. ... 554, * error out gracefully when `package.json`...
Read more >budget-justification-fy20220.pdf - HRSA
I am pleased to present the fiscal year (FY) 2022 Health Resources and Services Administration. (HRSA) Budget. HRSA is the primary Federal agency...
Read more >https://raw.githubusercontent.com/vigie/ng-packagr...
In case users want to emit closure compatible code, they need to install `tsickle` and enable opt it this feature. * We no...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
OK, but now
tsickle
is not a dependency of@angular/compiler-cli
how are teams using tsickle supposed to know which version oftsickle
is directly compatible with@angular
other than being on the latest version of both packages? If a user facing angularCompilerOption triggerstsickle
why shouldn’t it work out of the box? This seems like it will be very confusing for noobs.@alexeagle is looking at the right resolution, because for most developers tsickle is optional.