question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Update service worker doc getting started pre cli #693

See original GitHub issue

I’m submitting a…


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[ ] Feature request
[X ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
[ ] Other... Please describe:

Current behavior

Expected behavior

Comment from PR 23348: “This looks really good, just want to raise awareness that it will need updated once angular/angular-cli#693 gets merged, as it will also be updating the index.html file for the project which should be reflected here as well.”

Need to change service worker getting started where we list what the ng add command does.

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment


Angular version: X.Y.Z


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:7 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
jenniferfellcommented, Apr 27, 2018

@Brocco: Thanks!!

@chembu : This one’s ready to start work. Info above. Thanks!

1reaction
Broccocommented, Apr 27, 2018

I apologize, the right reference is this PR: angular/devkit#693 (which has since been merged).

@jenniferfell The docs look great, but there are a couple of things this command does which was not captured.

  • Updates index.html to include:
    • link to add the manifest.json
    • meta tags for Description and theme-color
  • Installs icon files to support the installed PWA
Read more comments on GitHub >

github_iconTop Results From Across the Web

ServiceWorkerRegistration.update() - Web APIs | MDN
The update() method of the ServiceWorkerRegistration interface attempts to update the service worker. It fetches the worker's script URL, ...
Read more >
Getting started with service workers - Angular
To set up the Angular service worker in your project, use the CLI command ng add @angular/pwa . It takes care of configuring...
Read more >
Handling service worker updates with immediacy
Sometimes when you update a service worker, it's good to let users know. Here, you'll learn how to do just that.
Read more >
Managing, monitoring, and updating the kernel Red Hat ...
Select the kernel you want to start when the GRUB 2 boot menu appears and press the e key to edit the kernel...
Read more >
Getting started with service workers - Angular
Adds the @angular/service-worker package to your project. · Enables service worker build support in the CLI. · Imports and registers the service worker...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found