URLMatchResult type should include null

🐞 bug report

Affected Package

URLMatcher is part of @angular/router

Is this a regression?

No

Description

Even in the example, is shown, that null, is to express that matcher didn’t match.

🔬 Minimal Reproduction

export function myMatcher(segments: UrlSegment[]): UrlMatchResult {
	return null;
}

🔥 Exception or Error

Type 'null' is not assignable to type 'UrlMatchResult'.

🌍 Your Environment

Angular Version:

Angular CLI: 7.1.2
Node: 9.11.1
OS: win32 x64
Angular: 7.2.4
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.11.2
@angular-devkit/build-angular     0.11.2
@angular-devkit/build-optimizer   0.11.2
@angular-devkit/build-webpack     0.11.2
@angular-devkit/core              7.1.2
@angular-devkit/schematics        7.1.2
@angular/cli                      7.1.2
@ngtools/webpack                  7.1.2
@schematics/angular               7.1.2
@schematics/update                0.11.2
rxjs                              6.4.0
typescript                        3.2.4
webpack                           4.23.1

[sambaptista]

This is a must have ! But in fact it already works. It seems to be just a typing issue.

myMatcher(...) : UrlMatcher // force to return non null value
myMatcher(...) // without return type, don't errors on build

The 2nd solution works as expected when returning null. The route is not activated.

It’s not “clean” but works.

[Akxe]

I see… well then…