Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Verify role against a list of allowed roles

See original GitHub issue

As discussed in #630, it would be hugely valuable to validate role values against a list of allowed roles. It is a relatively fixed list–the ones we’d want to allow include widget, document, and landmark roles. Abstract roles should throw a warning along with invalid ones.

Some examples that should throw errors:

role="image" – Error, not a valid role. Should be img.
role="input" – Error, abstract roles cannot be used directly. Should be textbox.

Specifying valid replacements like img instead of image would add complexity but would be super helpful.

Roles to allow:

Issue Analytics

State:
Created 9 years ago
Reactions:2
Comments:7 (4 by maintainers)

Top GitHub Comments

7reactions

angular-robot[bot]commented, Jun 10, 2021

Thank you for submitting your feature request! Looks like during the polling process it didn’t collect a sufficient number of votes to move to the next stage.

We want to keep Angular rich and ergonomic and at the same time be mindful about its scope and learning journey. If you think your request could live outside Angular’s scope, we’d encourage you to collaborate with the community on publishing it as an open source package.

You can find more details about the feature request process in our documentation.

1reaction

marcysuttoncommented, Jul 25, 2018

@splincode at this point it’s probably easier to integrate a tool like axe-core and its existing ARIA infrastructure into the Angular CLI or build system than to maintain a list of allowed roles in Angular. It’s a question of whether this should be done at runtime or build time…I wouldn’t think Angular would want to ship all the code for accessibility testing over the wire, so build time is probably better for accessibility testing. It could be run on save, in the test suite and in CI. I have some materials on doing that: http://marcysutton.github.io/a11y-testing-with-angular/#/

There’s also an issue open to integrate axe-core into Angular.io: https://github.com/angular/angular/issues/21969