disableRipple on list item leaves ripple class with overflow:hidden side effect
See original GitHub issueBug, feature request, or proposal:
Bug
What is the expected behavior?
When using disableRipple
on a list item, .mat-ripple
class should be removed.
What is the current behavior?
.mat-ripple
class remains on the mat-list-item-content
.
What are the steps to reproduce?
https://plnkr.co/edit/lO8Eudx4GFgevN4XAy3n?p=preview
What is the use-case or motivation for changing an existing behavior?
Justification here. The .mat-ripple
class adds overflow: hidden
.
It may be entirely valid that list items should always have overflow: hidden
on their content, but that should be done explicitly and not through a side effect of the ripple class.
Issue Analytics
- State:
- Created 6 years ago
- Comments:9 (8 by maintainers)
Top Results From Across the Web
MatRipple Continues To Show No Matter What - Stack Overflow
To remove the ripple effect you can just add the following to your styles.scss file: .mat-radio-ripple { display: none; }.
Read more >List - How to disable dx-list-item ripple effect on material theme
Hi, Is there any way to disable ripple effect on dx-list-item when material theme has been applied. You can check this.
Read more >HOW TO: create the ripple effect from Material Design
HOW TO: create the ripple effect from Material Design ... We could do this with CSS pseudo elements but the effect won't be...
Read more >UNPKG - @angular/material
_disableRipple = false;\n return _this;\n }\n Object.defineProperty(class_1.prototype, \"disableRipple\", {\n /**\n * Whether the ripple effect is disabled ...
Read more >JDI Light Framework - GitHub Pages
JDI Light Framework. JDI Light is a powerful Test Automation Framework that helps to make your tests fast, sustainable and provides obvious and...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Why not have the ripple container be a child of the list item that is
position: absolute; left: 0; top: 0; right: 0; bottom: 0
withoverflow: hidden
?This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.