select component - bug when used with reactive form - not usable inside formGroup
See original GitHub issueBug
when using a select component inside a reactive form, and updating the selection using the select component, the corresponding formControl is not being updated,
say I have a component that is inside formGroup:
html:
<form [formGroup]="formGroup">
<mat-form-field>
<mat-select placeholder="Pick item..." formControlName="selectedItem">
<mat-option *ngFor="let item of items">
{{item.name}}
</mat-option>
</mat-select>
</mat-form-field>
</div>
<button (click)="changeValue()">Change value</button>
component:
{
@ViewChild(MatSelect)selectComponent:MatSelect;
ngOnInit(){
this.formGroup = this.formBuilder.group({
selectedItem: ['', Validators.required],
});
this.items = [{name:'a'},{name:'b'},{name:'c'}];
}
changeValue(){
this.selectComponent.value = this.items[1];
}
}
when I press the “Change value” button, the selectComponent.value is being set, and the changes do reflect on the ui, but the corresponding formControl(selectedItem) is not being set and the form is invalid (the field is required)
What is the expected behavior?
the formControl should be updated with the value being set on the select component
What is the current behavior?
the formControl is not being updated
What are the steps to reproduce?
Providing a StackBlitz reproduction is the best way to share your issue.
StackBlitz starter: https://goo.gl/wwnhMV
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular CLI: 1.7.2
Node: 8.9.1
OS: win32 x64
Angular: 5.2.7
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router
@angular/cdk: 5.2.3
@angular/cli: 1.7.2
@angular/material-moment-adapter: 5.2.3
@angular/material: 5.2.3
@angular-devkit/build-optimizer: 0.3.2
@angular-devkit/core: 0.3.2
@angular-devkit/schematics: 0.3.2
@ngtools/json-schema: 1.2.0
@ngtools/webpack: 1.10.1
@schematics/angular: 0.3.2
@schematics/package-update: 0.3.2
typescript: 2.5.3
webpack: 3.11.0
Is there anything else we should know?
Issue Analytics
- State:
- Created 6 years ago
- Reactions:21
- Comments:18 (4 by maintainers)
Top Results From Across the Web
Cant set value to select in Reactive Form - Stack Overflow
Actually setValue and patchValue are seems working here. We check that with below approach.. this.tourPageForm.get('accomadation').
Read more >Can't Bind to formGroup Not Known Property Error in Angular
Let's take a look at why the “Can't bind to 'formGroup' since it isn't a known property of 'form'” error shows up and...
Read more >Handling large reactive forms in Angular | Articles - Sandro Roth
The problem. When you build a reactive form, you create a FormGroup with one or more FormControl in your component class, add some...
Read more >Disabling Form Controls When Working With Reactive Forms ...
It looks like you're using the disabled attribute with a reactive form directive. If you set disabled to true when you set up...
Read more >SelectControlValueAccessor - Angular
Using select controls in a reactive formlink ... import {Component} from '@angular/core'; import {FormControl, FormGroup} from '@angular/forms'; ...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
As the options are objects, it’s normal that the comparison fails when you select programmatically the value. You need to set a
compareWith
function (take a look at https://github.com/angular/material2/issues/6970#issuecomment-328355857):Aparently this is causing this behavior:
https://github.com/angular/material2/blob/915a2b732760eca047939acff7b79c00f7bc27e7/src/lib/select/select.ts#L394-L402
It looks like the
ControlValueAcessor
registered “onChange” function should have been called too: