Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Tabs] Position should not be exposed in documentation

See original GitHub issue

Bug, feature request, or proposal:

Bug

What is the expected behavior?

When setting the <md-card position=number> it should position the tab relative to other position numbers.

What is the current behavior?

position is ignored

What are the steps to reproduce?

https://plnkr.co/edit/Wp2JJ5hS9QwCyZLWqDEn?p=info

What is the use-case or motivation for changing an existing behavior?

When using tabs being able to dynamically position is important (generating in ngFor).

Issue Analytics

State:
Created 6 years ago
Comments:15 (8 by maintainers)

Top GitHub Comments

1reaction

willshowellcommented, Jul 23, 2017

@zbagley while you’re touching this, would you mind making a few other small doc changes for md-tab? If you don’t care to, I’ll take a crack later, but it would help clean up the tab api documentation page a lot!

templateLabel has a jsdoc comment that needs backtick escaping (<ng-template md-tab-label>)
I think origin should also not be exposed (leading underscore)
get content() should switch positions with private _contentPortal so that the jsdoc comment is immediately preceding content

cc @andrewseguin: can you verify #2 is a correct assumption? Also as to whether content should even be exposed to the public?

1reaction

julianobrasilcommented, Jul 22, 2017

Oh, Sorry. I’m typing from my android and not able to visualize plunks correctly.