Notify: false prevents state transition entirely (not just events)

Hi,

I’ve created a Plunker here

As shown in the example I think one would expect to be able to use event.preventDefault() in the $stateChangeStart event to prevent a transition, then later trigger that same transition manually with {notify: false} to prevent the event being triggered and therefore the state transition being blocked again (infinite loop).

However the viewDirective is relying on $stateChangeSuccess internally which is also prevented by {notify: false}.

One work around is like so:

$state.go(toState.name, toParams, {notify: false}).then(function() {
    $rootScope.$broadcast('$stateChangeSuccess', toState, toParams, fromState, fromParams);
});

I think perhaps the best solution here would be to use an alternative event internally to trigger the updateView() in viewDirective, or alternatively extend notify to target start/success events separately.

Thanks

[christopherthielen]

For anyone searching, there will not be updates on this issue because 1.0 deprecates the state events. {notify: false} no longer has any effect.

[christopherthielen]

@pootzko that depends on what you’re trying to do (assuming with notify: false). In @homerjam’s example, I think managing the infinite loop using a separate variable like retryInProgress would work.

$on("$stateChangeStart", event, to, toParams) {
  if (to.retryInProgress) {
    to.retryInProgress = false;
    return;
  }
  // do  stuff
  event.preventDefault();
  to.retryInProgress = true;
  $state.go(to, toParams);
}

@leonpapazianis yes, it is on the roadmap. You can use the proof-of-concept I added to ui-router-extras for now. See #1257 for details. I think code like this should work:

$on("$stateChangeStart", event, to, toParams) {
  // UI-Router Extras decorates the injector so you can do this in a event handler... 
  // UI-Router 1.0 will only allow $transition$ injection in places where resolves are normally injected.
  var t = $injector.get("$transition$"); 
  t.promise.then(transitionSuccessFn);
}