Fix for exercice download + bug report about exercice download

Please follow the guide below

• You will be asked some question, please read them carefully
• Put an x into all the boxes [ ] relevant to your issue (like this: [x])
• Use the Preview tab to see what your issue will actually look like

---

Make sure you are using the latest version: run git pull to update your version from Lyndor directory

Before submitting an issue make sure you have:

What is the purpose of your issue?

• At least skimmed through the README
• Bug report (encountered problems with Lyndor) 🪲
• Question ❓
• Feature request (request for a new functionality) ☝️
• Other

---

If the purpose of this issue is a bug report, or you are not completely sure then provide the full terminal output as follows:

Copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):

Videos downloaded: 16

🔰  Moving files inside: 00. Introduction
🔰  Moving files inside: 01. Foundations of Salary Negotiations
🔰  Moving files inside: 02. The Negotiation Conversation
🔰  Moving files inside: 03. Special Considerations
🔰  Moving files inside: 04. After the Negotiation

🥂  videos/subtitles moved to appropriate chapters successfully.

Exercise file is available to download

library card no. and card pin. entered successfully....
launching desired course page ....
Downloading Ex_Files_Negotiating_Your_Salary.zip
Download in progress ./Users/othmanelamnabhi/Desktop/Lyndor/exercise_file.py:57: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal
  if folder == ex_file_name:
Download in progress ................

---

Answer questions related to your Environment which will help in reproducing the issue:

The issue was encountered on: 💻

• MacOS
• Windows
• Linux

Enter the python version you are using for download. Find your python version by typing in terminal python -V

• python 2.7.10 (happens also with 3.6.4)

---

If the purpose of this issue is a bug report please provide all kinds of example URLs where you encountered issues (replace following example URLs by yours):

https://www.lynda.com/Business-tutorials/Negotiating-Your-Salary/702267-2.html

---

Description of your issue, suggested a solution and other information

I tried to download a course through my library login, the videos download just fine, but when it launches Chrome to download the exercice files, the login fails, when I compared the login url to the url in exercise_file.py I found out that I had to replace “sip” by “patron” in the organization login, then when I redownloaded the course, Chrome launched properly and logged in properly, but now the issue I face is that Lyndor downloads the file into the “Downloads” folder and then terminal gets stuck at “Download in progress” although the file is done downloading and I get that error UnicodeWarning.

[ankitsejwal]

Hi @Otech-Man python doesn’t make sense of plural or singular its just a convention I use, the exercise can be written as x as you see in some examples:

# the x 
list = [0, 1, 2]
for x in list:
    print(x)
# output:
0
1
2
# Hence the x is just defined in 'for' statement and it will die after this for loop so to say. 
# x will act as a variable to hold the current item in the iteration, so it will be first 0 then 1 then 2

The above example can also be written as you attempted earlier

list = [0, 1, 2]
for x in range(0, len(list)- 1):
     print(x[0])
# output: same as before

# Hence you can see the previous example is favorable in some cases as the syntax is simpler, 
# sort of plain english -> for exercise in exercises (The magic of python: simplicity :)  )

Cheers ANk

[othmanelamnabhi]

OMG its WORKS @ankitsejwal 👍 I commented out the 4 last operations in run.py to allow the script to create the directory it was gonna move the file to. I initially got here because I was looking for a way to download the courses, and honestly I could have just left it at that and downloaded the exercices files manually at the end, but I like things perfect and I’m glad you were here for support. I’m thankful for the exchange, because as I told you I never programmed, but I can read strings of code until they kinda make sense to me. So I learned a lot from yours. Thank you for the explanation, I finally understand now why it took so long, and the verbose mode you added helped with that. I have a huge downloads folder so it was taking time but it’s working amazingly well now.

One last thing, you told the “sip” parameter was working for some other user. If he ever ends up answering and the sip parameter works for him, either a conditional statement could be added where if login fails for one it reverts to the other parameter, or honestly it can just be done manually and that’s the end of it.

But an in all, I had fun with this, and I have you to thank for a great weekend spent experimenting.