Installing roles with dashes in the name is broken

Bug Report

SUMMARY

I used to be able to install roles with dashes in the name, e.g. elliotweiser.osx-command-line-tools. I can no longer do so. It appears that underscores are required. This breaks roles and playbooks that pull in such roles as dependencies.

Example: https://travis-ci.org/geerlingguy/mac-dev-playbook/builds/398684539

STEPS TO REPRODUCE

pip install ansible # occurs w/ 2.6 and 2.5
ansible-galaxy install elliotweiser.osx-command-line-tools

EXPECTED RESULTS

The role should be successfully downloaded.

ACTUAL RESULTS

$ ansible-galaxy install elliotweiser.osx-command-line-tools
- downloading role 'osx-command-line-tools', owned by elliotweiser
 [WARNING]: - elliotweiser.osx-command-line-tools was NOT installed successfully: - sorry, elliotweiser.osx-command-line-tools was not
found on https://galaxy.ansible.com.

ERROR! - you can use --ignore-errors to skip failed roles and finish processing the list.

It appears the role can only be installed when using underscores instead of dashes:

$ ansible-galaxy install elliotweiser.osx_command_line_tools
- downloading role 'osx_command_line_tools', owned by elliotweiser
- downloading role from https://github.com/elliotweiser/ansible-osx-command-line-tools/archive/2.1.0.tar.gz
- extracting elliotweiser.osx_command_line_tools to /Users/elliotweiser/git/github/elliotweiser/elliotweiser.osx_command_line_tools
- elliotweiser.osx_command_line_tools (2.1.0) was installed successfully

I’m not sure if this was change in behavior was intentional, but it may have been an oversight.

[chouseknecht]

@paulfantom

That last one is fixed. It’s now ‘mysqld-exporter’.

Going forward, anything new will have ‘-’ converted to ‘_’.

If you want to alter the name (e.g., remove ‘ansible-’), then use the role_name attribute to set the name.

Deleting a role and re-importing, or setting the role_name value, will update the name in the Galaxy database, and cause ‘-’ to be converted to ‘_’.

[elliotweiser]

Some additional irony…

This URL looks good 👍 https://galaxy.ansible.com/elliotweiser/osx-command-line-tools

This one, not so much… https://galaxy.ansible.com/elliotweiser/osx_command_line_tools