question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

grey doesn't match the documentation

See original GitHub issue

When I try to use grey from this library, it outputs:

[
  '#a6a6a6',
  '#999999',
  '#8c8c8c',
  '#808080',
  '#737373',
  '#666666',
  '#404040',
  '#1a1a1a',
  '#000000',
  '#000000',
  primary: '#666666'
]

However, the spec / documentation (https://ant.design/docs/spec/colors) indicates that grey should be:

[                                                                             
'#ffffff',                                                                          
'#fafafa',                                                                          
'#f5f5f5',                                                                          
'#e8e8e8',                                                                          
'#d9d9d9',                                                                          
'#bfbfbf',                                                                          
'#8c8c8c',                                                                          
'#595959',                                                                          
'#262626',                                                                          
'#000000',                                                                          
]  

This issue is easy enough to workaround, but I thought a fix might help out a lot of folks. Thanks!

Issue Analytics

  • State:open
  • Created 4 years ago
  • Reactions:27
  • Comments:6

github_iconTop GitHub Comments

1reaction
carmanchris31commented, Jun 30, 2020

Note that the spec now has an expanded grey palette with 13 values:

#ffffff
#fafafa
#f5f5f5
#f0f0f0
#d9d9d9
#bfbfbf
#8c8c8c
#595959
#434343
#262626
#1f1f1f
#141414
#000000

https://ant.design/docs/spec/colors#Neutral-Color-Palette

This was discussed in the 4.0 announcement here: https://zhuanlan.zhihu.com/p/112470365

There’s a lot of talk about how the dark colors have to be considered differently (versus simply flipping the order of the light colors), but it’s only shown applied to the primary colors, so it’s not clear what the presetDarkPalettes.grey export should look like.

0reactions
shifraHolzercommented, Jun 30, 2021

I, too, would like this to have a neater solution.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Document Verification - Grey Help Center
Edited and altered documents are not supported. The person on the ID must match the video selfie. The details on the ID must...
Read more >
slds-table css styling no longer makes header row grey ...
The first example, the 'Base' styling, clearly shows a grey header row in the example.
Read more >
Header and Body Font Colors Don't Match?
The grey part is just to indicate that that section is currently not active for editing. It tells nothing about the color of...
Read more >
Color Profile Mismatch - Ask Tim Grey
... message that the document has an embedded color profile that does not match the RGB working space (Monitor RGB – Color LCD...
Read more >
Color conversion and ink management (Acrobat Pro)
Convert object colors ... If certain objects in the PDF don't match the color space of the document, you can use the Edit...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found