Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

default Icon theme is missing in react and vue adaptors

See original GitHub issue

Hello! I am trying to build some components libs on top of ant-design for internal usages.

Included the the ant-design as dependencies and use rollup to bundle it up.

After that I start a create-react-app application and test it out for my components libs.

And getting this errors:

It seem the angular adaptor will passing the default theme when then theme is undefined

https://github.com/ant-design/ant-design-icons/blob/f8cac49b8ce9909e222a16202fdf6014cdd1dc13/packages/icons-angular/lib/component/icon.directive.ts#L69

but seem the vue and react did not share the same behaviour

https://github.com/ant-design/ant-design-icons/blob/9ba5f3fdc1d6bf7011cbb28e48e53d164c33b6d1/packages/icons-react/src/components/Icon.tsx#L40

https://github.com/ant-design/ant-design-icons/blob/ccfc791bf175801e5fd28e23f37345d596f0780b/packages/icons-vue/src/components/Icon.jsx#L27

Maybe we should unify the this behaviour across different platform

Issue Analytics

State:
Created 5 years ago
Comments:7

Top GitHub Comments

1reaction

Toronecommented, Aug 21, 2020

@hongchanhk01 Can I know how did you fix the rollup configuratiuon to avoid this annoying issue? Thanks

0reactions

htmlincommented, Nov 17, 2020

@hongchanhk01 Can I know how did you fix the rollup configuratiuon to avoid this annoying issue? Thanks

Top Results From Across the Web

vue.js - vuetify icon not showing - Stack Overflow

Had this issue with Vuetify 2.1.3 installed via the vuetify-loader 1.2.2. Seems like previous solutions do not work becues the default icons ......

Changelog - Shoelace

Changelog. Shoelace follows Semantic Versioning. Breaking changes in components with the Stable badge will not be accepted until the next major version.

dev-sample-test-xx - npm Package Health Analysis | Snyk

React UI Check/Radio [RadioGroup, Checkbox(s)] (BEST-CUSTOMIZE ALL) For more information about ... You can customize icon, theme or color for Checkbox/Radio.

Editor toolbar - CKEditor 5 Documentation

The default icons are loaded from the ckeditor5-core package. If no icon is specified, 'threeVerticalDots' will be used as a default. If icon:...

Debug Node.js Apps using Visual Studio Code

Setting up a project for Node.js debugging is straightforward with VS Code providing appropriate launch configuration defaults and snippets.