Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Modal footer divider persists when buttons removed

See original GitHub issue

The Modal component shows the bottom divider when the footer prop is set to null.

Environment(required)

antd version 2.8.0:
macOS Sierra (version 10.12.3):
Chrome version 56.0.2924.87 (64-bit)

What did you do? Please provide steps to re-produce your problem.

Render Modal component with the visible prop true and the footer prop as some non-null element.
Update the footer prop to null
BUG bottom divider continues to show even though footer content is null.

What do you expected?

I would expect the footer section and divider to be hidden as it is in this image. footer_hidden

What happen?

It is not hidden. divider_visible

Issue Analytics

State:
Created 6 years ago
Comments:11 (7 by maintainers)

Top GitHub Comments

1reaction

benjycuicommented, Mar 24, 2017

It seems that we cannot set Modal[footer=null] to hide footer now.

But we can update this line of code to achieve your target:

footer={footer === undefined ? defaultFooter : footer}

0reactions

lock[bot]commented, May 1, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.