question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Feature Request] Support for the new personalized button

See original GitHub issue

First off, thanks for the amazing library!

It seems like google recently(?) made an upgrade to the login button. It’s now more personalized. developers.google.com/identity/gsi/web/guides/personalized-button

I’ve tried playing around with the library to get the personalized button to work but I’m coming up empty-handed. Is it possible to get support for this new button?

I’d be happy to make a PR if I could just get a hint on what needs to be done, and how cumbersome the implementation might be?

I came to this library because, even though it’s trivial to get the button to show on the page (copy paste from here: developers.google.com/identity/gsi/web/guides/display-button ), it gave me an error I couldn’t figure out how to solve, which I guess is the whole reason why this package exist. invalid value for prop data-callback on <div> tag

Thanks!

Issue Analytics

  • State:open
  • Created 2 years ago
  • Comments:6

github_iconTop GitHub Comments

3reactions
leopuccicommented, Aug 19, 2021

Nice job @MrEmanuel I am also looking on how to do this. I don´t want a floating login (one tap) as I find this annoying and people are already blocking (https://superuser.com/questions/1414410/how-to-disable-google-one-tap-sign-up-prompts)

There are already some modules that do one tap if you are looking for this. (https://www.npmjs.com/package/react-google-one-tap-login)

I do think that a personalized button is better than a pop up forcing the user. I wish I could see your mods inside react-google-login module

1reaction
MrEmanuelcommented, Sep 18, 2021

@MrEmanuel Is support for the new API going to be coming in a future release?

I’m not a maintainer of this package so I unfortunately can’t give you an answer.

I can only say that I’m not planning on making a PR. The implementation I need and use is documented in my article in the link in the previous comment

Read more comments on GitHub >

github_iconTop Results From Across the Web

Feature Request – Change Add to Cart Button - WordPress.org
Feature Request – Change Add to Cart Button ... The easiest way to solve it is to add this custom code to the...
Read more >
Feature requests - Novashare
[05.20.22] Support for Odnoklassniki network. [05.10.22] Ability to use custom SVGs for social share buttons. [02.27.22] Add a like/love button.
Read more >
Feature Requests - Kadence Blocks
Please Login to submit a request. Submit. Vote for an existing request (574) or Post a new request. Latest ...
Read more >
Feature Request Handling: How a SaaS Company Obsessed ...
That button sent new feature requests to the moon and is responsible for a huge part of ... customer interviews, and customer support...
Read more >
How to create a Feature Request - THWACK Documentation
Before creating a new feature request, you should search for a ... In the Feature Request space click the green "CREATE" button in...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found