Not Challenged to Accept Terms of Service or Privacy Policy on Registration
See original GitHub issueBug Report or Feature Request (mark with an x
)
- [X] bug report -> please search issues before submitting
- [ ] feature request
OS and Version?
Mac Sierra 10.12.6
Versions
Angular CLI: 7.1.4 Node: 11.0.0 OS: darwin x64 Angular: 7.2.1 … cdk, compiler, core, forms, http
Package Version
@angular-devkit/architect 0.11.3 @angular-devkit/build-angular 0.11.3 @angular-devkit/build-optimizer 0.11.3 @angular-devkit/build-webpack 0.11.3 @angular-devkit/core 7.1.3 @angular-devkit/schematics 7.1.4 @angular/animations 7.1.4 @angular/cli 7.1.4 @angular/common 7.1.4 @angular/compiler-cli 7.1.4 @angular/fire 5.1.1 @angular/flex-layout 7.0.0-beta.22 @angular/language-service 7.1.4 @angular/material 7.1.1 @angular/platform-browser 7.1.4 @angular/platform-browser-dynamic 7.1.4 @angular/router 7.1.4 @ngtools/webpack 7.1.3 @schematics/angular 7.1.4 @schematics/update 0.11.4 rxjs 6.3.3 typescript 3.1.6 webpack 4.23.1
Repro steps
- Add tosUr and/or privacyPolicyUrl to <ngx-auth-firebaseui>
- Register a user
- Not asked to check and accepts tos and pp
The log given by the failure
None
Desired functionality
I am challenged to accept terms of service and/or privacy policy before creating an account.
Mention any other details that might be useful
I am basing my understanding of the software based on this entry in the readme.
PS: if either tosUrl or privacyPolicyUrl are provided, the user will be asked to check and accepts tos and pp before registering a new account or sign in in anonymously.
Also, looked at #80 and its related commit 67683517e0fba4168f97b29c71912e82902c4df7. It looks like the legality dialog only open for guest only and not registration. It would be nice to have this or a simple set of checkboxes by a disabled register button.
Issue Analytics
- State:
- Created 5 years ago
- Comments:12 (6 by maintainers)
I believe an overlay modal would be best choice as it emphasis the acceptance of terms and conditions. Cheers…
Sent from my iPhone
Just look at the code of
ngx-auth-firebaseui-register
component, and the functionality is totally missing.I think a solution may be to adapt the
ngx-auth-firebaseui
component to act as a register component.